Magnus Hagander wrote:
> >> > As I mentioned offlist, I'd like it in teal please.
> >>
> >> Applied with some further minor bikeshedding (remove trailing spaces,
> >> rewrap so columns aren't wider than 80 chars, etc)
> >
> > Let me just point out that people who have already run initdb during
> > beta will not see this in their pg_hba.conf, nor in their
> > share/pg_hba.conf.sample, even after they have upgraded to a later beta,
Oops, yes, I was wrong here. Sorry.
> > unless they run initdb. ?However, we have bumped the catalog version for
> > something else so they should then get this change.
>
> Why would they not see it in their share/pg_hba.conf.sample?
>
> It will not affect the existing one in $PGDATA, but why wouldn't the
> installed .sample change?
Yes, the problem is the sample will change, but the $PGDATA will not, so
anyone doing a diff of the two files to see the localized changes will
see the changes that came in as part of that commit.
> > My point is if we change configuration files and then don't bump the
> > catalog version, the share/*.sample files get out of sync with the files
> > in /data, which can be kind of confusing.
>
> They would - but what you are saying above is that they would not get
> out of sync, because the share/*.sample also don't update. Just a
> mistake in what you said above, or am I missing something?
Yes, my mistake.
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ It's impossible for everything to be true. +
