Re: superfluous copydir() prototype in pg_upgrade.h - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: superfluous copydir() prototype in pg_upgrade.h
Date
Msg-id 201007011437.o61Ebv105009@momjian.us
Whole thread Raw
In response to Re: superfluous copydir() prototype in pg_upgrade.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > While looking at Guillaume Lelarge's patch to add
> > CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
> > have a $SUBJECT.
> 
> > Trivial patch attached.
> 
> The rmtree() declaration below it shouldn't be there either ...

When pg_upgrade was not in /contrib, I was concerned about including
port.h, but at this point, I think it is fine.  Both removed.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + None of us is going to be here forever. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: superfluous copydir() prototype in pg_upgrade.h
Next
From: Robert Haas
Date:
Subject: Re: bitmap indexes - performance