On Mon, Feb 08, 2010 at 08:20:04PM -0500, Tom Lane wrote:
> > MSVC builds are broken from a missing _isnan function on the ECPG tests.
> > Do we need to link in a math lib or something there?
>
> It looks to me like the problem is that that test is being compiled
> without benefit of any platform-dependent code whatsoever. In the rest
> of the system, isnan and isinf work on WIN32 because the compiles can
> see the macro definitions in port/win32.h. nan_test is apparently not
> including that. I'm not sure of Michael's plan for portability of
> these test cases --- if he doesn't want to include c.h or something
> close to that, I think the nan test has to go away.
Actually I was hoping someone with some Windows experience would take a look at
it or Zoltan would come up with a fix, after all it was his addition. :-)
Looking at the portability header file it appears that isnan/isinf are only one
line defines, so it doesn't look like a major problem adding these. I will try
fixing this, but bear with me as I have to use the buildfarm for testing. I
don't have a Windows build environment.
If someone is willing to run a test on Windows for me, please tell me.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes@jabber.org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
