Re: patch to implement ECPG side tracing / tracking ... - Mailing list pgsql-hackers

From Michael Meskes
Subject Re: patch to implement ECPG side tracing / tracking ...
Date
Msg-id 20100113133807.GA31808@feivel.credativ.lan
Whole thread Raw
In response to patch to implement ECPG side tracing / tracking ...  (Hans-Jürgen Schönig <hs@cybertec.at>)
Responses Re: patch to implement ECPG side tracing / tracking ...  (Hans-Juergen Schoenig <hs@cybertec.at>)
List pgsql-hackers
Hans,

nce Jaime already asked for a use case, just a few small comments from
me.

> @@ -4,6 +4,7 @@
>  #include "postgres_fe.h"
>
>  #include <ctype.h>
> +#include <inttypes.h>

This is not portable. You don't want to include this header.

Did I see this right that you use the statement cache for auto-prepared
statements even if the statement is not auto prepared? Some statements are not
profiled, how did you decide which one to do? 

There is no test case.

Before looking into it in detail I think we should first figure out if this
feature really has a benefit.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL


pgsql-hackers by date:

Previous
From: Hitoshi Harada
Date:
Subject: Re: More frame options in window functions
Next
From: Michael Meskes
Date:
Subject: Re: ECPG patch causes warning