Re: autovacuum launcher using InitPostgres - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: autovacuum launcher using InitPostgres
Date
Msg-id 20090831153816.GF6060@alvh.no-ip.org
Whole thread Raw
In response to Re: autovacuum launcher using InitPostgres  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: autovacuum launcher using InitPostgres  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > To this end, InitPostgres has been split in two.  The launcher only
> > calls the first half, the rest of the callers have been patched to
> > invoke the second half.
> 
> This just seems truly messy :-(.  Let me see if I can find something
> cleaner.

I was considering having InitPostgres be an umbrella function, so that
extant callers stay as today, but the various underlying pieces are
skipped depending on who's calling.  For example I didn't like the bit
about starting a transaction or not depending on whether it was the
launcher.

> BTW, is it *really* the case that the AV launcher won't need
> RecentGlobalXmin?  The way the HOT stuff works, I think anything that
> examines heap pages at all had better have that set.

Ugh.  I forgot about that.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Hans-Juergen Schoenig -- PostgreSQL
Date:
Subject: Re: combined indexes with Gist - planner issues?
Next
From: Tom Lane
Date:
Subject: Re: autovacuum launcher using InitPostgres