Re: encoding cleanups in cvs repo - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: encoding cleanups in cvs repo
Date
Msg-id 20081223152740.GD6217@alvh.no-ip.org
Whole thread Raw
In response to Re: encoding cleanups in cvs repo  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Tom Lane wrote:
> >> Out of curiosity ... what problems exactly?  I just looked through my
> >> last complete dump of CVS log history and didn't see anything funny
> >> in the messages for exc.c ...
> 
> > It's rev 1.7 of that file -- it had a ^E and a ^L.
> 
> Ah, I was looking for high-bit-set characters.

Right, we have our share of those too, but Magnus is filtering them with
iconv or Python internal recoding routines, and they don't cause
problems.  However those routines were not touching those control chars,
and later steps of the process were choking on them.

> Yeah, I see those.  The backtick is clearly the right thing if you
> compare to the adjacent commit message for another branch.

Right, and it's the usual quoting rule used by FSF stuff (and others I
assume).

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: "Robert Haas"
Date:
Subject: Re: Proposed Patch to Improve Performance of Multi-Batch Hash Join for Skewed Data Sets
Next
From: Simon Riggs
Date:
Subject: Re: Sync Rep: First Thoughts on Code