Re: initdb change - Mailing list pgsql-hackers

From Joshua Drake
Subject Re: initdb change
Date
Msg-id 20080825102615.62bc600e@jd-laptop
Whole thread Raw
In response to Re: initdb change  (David Fetter <david@fetter.org>)
Responses Re: initdb change  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Mon, 25 Aug 2008 10:12:03 -0700
David Fetter <david@fetter.org> wrote:

> > /var/lib/pgsql/data/ exists but is empty you can initdb within that
> > directory. However if there is anything in it you can not. You are
> > asking that if pg_xlog exists but is empty that we still be able to
> > use the DATADIR and you can pass existing so that it will also use
> > pg_xlog if it is empty.
> >
> > My take would be to not add a new flag. Instead to implicitly allow
> > it. If initdb finds that DATADIR and pg_xlog is empty it will use
> > both.
>
> Is there some reason why initdb shouldn't just Do The Right Thing™
> when it finds an empty extant $PGDATA/pg_xlog directory that passes
> the same tests an empty extant $PGDATA would?

That is what I was suggesting.

Joshua D. Drake

>
> Cheers,
> David.


--
The PostgreSQL Company since 1997: http://www.commandprompt.com/
PostgreSQL Community Conference: http://www.postgresqlconference.org/
United States PostgreSQL Association: http://www.postgresql.us/
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate




pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: initdb change
Next
From: Jeff Davis
Date:
Subject: Re: WIP patch: reducing overhead for repeat de-TOASTing