Re: Proposed patch - psql wraps at window width - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Proposed patch - psql wraps at window width
Date
Msg-id 200805030032.m430WQq20933@momjian.us
Whole thread Raw
In response to Re: Proposed patch - psql wraps at window width  (Bryce Nesbitt <bryce2@obviously.com>)
List pgsql-hackers
Bryce Nesbitt wrote:
> Tom Lane wrote:
> > Well, personally I haven't read the core code yet, since it's not commit fest yet ;-).  I don't know whether there
areany issues there, but it wouldn't surprise me given the number of issues in the control code.
 
> >
> >             regards, tom lane
> >   
> 
> I'm biased because I wrote the patch.  However -- I think the core is 
> commitable (it won't break anything else, or have complex dependencies 
> or bloat).
> 
> The issue of $COLUMNS was identified as unresolved at the time the patch 
> was submitted, and I think it's the only bit in serious question.

This code is complicated.  There is no need to rush and have to revisit
it later.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: ecpg localization
Next
From: Bruce Momjian
Date:
Subject: Re: Proposed patch - psql wraps at window width