Re: Lessons from commit fest - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Lessons from commit fest
Date
Msg-id 20080417111617.45ab18f3@mha-laptop
Whole thread Raw
In response to Re: Lessons from commit fest  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Lessons from commit fest
List pgsql-hackers
Bruce Momjian wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Bruce Momjian <bruce@momjian.us> writes:
> > > > I am reviewing the psql wrap patch and just used pgindent today
> > > > to clean it up.  (pgindent did not add any extra spacing
> > > > changes.)  Patch reviewers should probably be able to run
> > > > pgindent.
> > > 
> > > Well, that means nobody in the world can review except you,
> > > because nobody else has ever reported success in duplicating your
> > > pgindent results.  I know I haven't been able to.
> > > 
> > > If you really believe the above then you need to try a bit harder
> > > to find a portable version of indent that we all can use.
> > 
> > The source code of pgindent I use is on our ftp site.  find_typedefs
> > should now work on Linux as well as BSD.  Not sure what else would
> > be a problem.
> 
> Also I can put up a web page where you can upload or email your C file
> and get a formatted version back.

IIRC, last time I tried it, the failure was because I couldn't get it
to build the proper typedefs. Any chance you could just put a regularly
updated typedefs file somewhere that I could wget down?

//Magnus


pgsql-hackers by date:

Previous
From: PFC
Date:
Subject: Re: count(*) performance improvement ideas
Next
From: Alvaro Herrera
Date:
Subject: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit could leave shared memory