Re: Lessons from commit fest - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Lessons from commit fest
Date
Msg-id 200804162308.m3GN8kx20330@momjian.us
Whole thread Raw
In response to Re: Lessons from commit fest  (Chris Browne <cbbrowne@acm.org>)
Responses Re: Lessons from commit fest  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Chris Browne wrote:
> > That is much a more radical use of pgindent than it has had in the past
> > but it is certainly possible.
> 
> Well, supposing you're cleaning up a patch after someone has generated
> it in bad style, it would seem like rather less work to use pgindent
> to impose style policy right away rather than simulating its effects
> manually.

I am reviewing the psql wrap patch and just used pgindent today to clean
it up.  (pgindent did not add any extra spacing changes.)  Patch
reviewers should probably be able to run pgindent.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: Re: How to submit a patch
Next
From: "Stephen Denne"
Date:
Subject: Re: count(*) performance improvement ideas