Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Peter Eisentraut <peter_e@gmx.net> writes:
> > > > Am Samstag, 10. November 2007 schrieb Bruce Momjian:
> > > >> Use strip -x on OS/X-darwin because non-"-x" causes link problems:
> > >
> > > > How will this work, considering that $template isn't set anywhere?
> > >
> > > It won't, of course. Perhaps something like
> > >
> > > if test `uname -s` = Darwin
> > >
> > > instead.
> >
> > I am afraid some unames don't have -s, so I did uname -a and tested for
> > it starting with Darwin. Patch attached and applied.
>
> Hmm, this doesn't seem to work for me:
>
> $ if test expr "`uname -a`" : 'Darwin' -ne 0
> > then stripprog="${STRIPPROG-strip -x}"
> > else stripprog="${STRIPPROG-strip}"
> > fi
> -bash: test: too many arguments
Sorry, corrected patch attached, tested, and applied.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: config/install-sh
===================================================================
RCS file: /cvsroot/pgsql/config/install-sh,v
retrieving revision 1.6
diff -c -c -r1.6 install-sh
*** config/install-sh 13 Nov 2007 18:15:01 -0000 1.6
--- config/install-sh 13 Nov 2007 18:50:34 -0000
***************
*** 59,65 ****
# Darwin normal strip removes symbols from shared libraries
# that are later needed for dynamic linking, so use strip -x.
# http://archives.postgresql.org/pgsql-hackers/2007-10/msg01470.php
! if test expr "`uname -a`" : 'Darwin' -ne 0
then stripprog="${STRIPPROG-strip -x}"
else stripprog="${STRIPPROG-strip}"
fi
--- 59,65 ----
# Darwin normal strip removes symbols from shared libraries
# that are later needed for dynamic linking, so use strip -x.
# http://archives.postgresql.org/pgsql-hackers/2007-10/msg01470.php
! if test `expr "\`uname -a\`" : 'Darwin'` -ne 0
then stripprog="${STRIPPROG-strip -x}"
else stripprog="${STRIPPROG-strip}"
fi