Re: [COMMITTERS] pgsql: Adjust script to be consistent (thanks Tom for the fix). - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [COMMITTERS] pgsql: Adjust script to be consistent (thanks Tom for the fix).
Date
Msg-id 200711130427.lAD4Rjs07233@momjian.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Adjust script to be consistent (thanks Tom for the fix).  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Tom Lane wrote:
> >> Pray tell, why do you think it's a good idea to not have version labels
> >> in the contrib scripts?
>
> > If we want them, they should be in all of them.
>
> +1 for putting the label in all of them --- these files end up "loose"
> in user installations, so having a clear version identity on them seems
> like a Real Good Idea.
>
> > I am worried slightly
> > that a version label will make the SET search_path harder to find, though.
>
> The documentation already says "first command", and there is already
> one comment in front of that.  I don't think having two comments in
> front of it will deter anyone smart enough to be installing contrib
> modules into nonstandard schemas.

Agreed.  Done.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Simplifying Text Search
Next
From: Greg Smith
Date:
Subject: Re: How to keep a table in memory?