Re: type money causes unrestorable dump - Mailing list pgsql-hackers

From D'Arcy J.M. Cain
Subject Re: type money causes unrestorable dump
Date
Msg-id 20071103154208.36ebc82a.darcy@druid.net
Whole thread Raw
In response to Re: type money causes unrestorable dump  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: type money causes unrestorable dump  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, 03 Nov 2007 14:39:48 -0400
Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "D'Arcy J.M. Cain" <darcy@druid.net> writes:
> > I never received a response on this.  Here is the full diff with the
> > above change.  Since it is documentation and not code, is it OK to
> > commit this now?
> 
> The added text needs some copy-editing, I think.  How about
> 
>     Since the output of this data type is locale-sensitive, it may not
>     work to load <type>money</> data into a database that has a different
>     setting of <varname>lc_monetary</>.  To avoid problems, before
>     restoring a dump make sure <varname>lc_monetary</> has the same value
>     as in the database that was dumped.
> 
> (Actually, the first of the two lc_monetary references should be
> an xref link to the GUC variable, but I'm too lazy to type that out.)
> 
> A more direct approach to the problem might be to change pg_dump to
> set lc_monetary, as it does for client_encoding ...

Certainly OK by me.

-- 
D'Arcy J.M. Cain <darcy@druid.net>         |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 425 1212     (DoD#0082)    (eNTP)   |  what's for dinner.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: CREATE CONSTRAINT TRIGGER compatibility issue
Next
From: Bruce Momjian
Date:
Subject: Re: Text <-> C string