On Tue, Aug 07, 2007 at 06:53:48PM +0100, Simon Riggs wrote:
> On Tue, 2007-08-07 at 18:25 +0530, Pavan Deolasee wrote:
>
> > I am posting the version 13 of HOT patch on pgsql-patches. It
> > includes the changes based on feedback received on version 11.
>
> I think we need a change log, so we can see which feedback has resulted
> in changes and which has not. Otherwise we'll end up needing to re-read
> the patch frequently. I'll be straight up and say I don't read every
> version you put out, especially in recent months. You can really expect
> most people to eyeball it only once, so we need a way to ensure every
> reviewer's comment that results in a change is tracked.
>
> I wish I had done this myself with async commit, though the
> changes/suggestions were relatively modest in comparison to HOT.
>
> Perhaps if we start that from now on? That will help as we move towards
> final reviews and commit. We seem to be discussing smaller aspects of
> the patch now.
Perhaps also posting a diff of the patch versions would help, so that
you can easily see exactly what code has changed since last time...
--
Decibel!, aka Jim Nasby decibel@decibel.org
EnterpriseDB http://enterprisedb.com 512.569.9461 (cell)
