Re: Frustrating issue with PGXS - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Frustrating issue with PGXS
Date
Msg-id 200706271030.49754.peter_e@gmx.net
Whole thread Raw
In response to Re: Frustrating issue with PGXS  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Frustrating issue with PGXS  (Fabien COELHO <coelho@cri.ensmp.fr>)
Re: Frustrating issue with PGXS  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Am Dienstag, 26. Juni 2007 16:12 schrieb Tom Lane:
> True.  OK, then let's add the ifndef to Makefile.global and change the
> existing extension makefiles to
>
>         PG_CONFIG := pg_config
>         PGXS := $(shell $(PG_CONFIG) --pgxs)
>         include $(PGXS)
>
> Any objections?

Yes.  I think that solution is wrong.  It merely creates other possibilities 
to use mismatching combinations.  What was the problem with just making all 
uses of pg_config in Makefile.global use a hardcoded bindir directly?

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/


pgsql-hackers by date:

Previous
From: "Pavan Deolasee"
Date:
Subject: Re: HOT: Incomplete issues
Next
From: Teodor Sigaev
Date:
Subject: Re: tsearch in core patch