Re: Frustrating issue with PGXS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Frustrating issue with PGXS
Date
Msg-id 18357.1182867136@sss.pgh.pa.us
Whole thread Raw
In response to Re: Frustrating issue with PGXS  (Fabien COELHO <fabien.coelho@ensmp.fr>)
Responses Re: Frustrating issue with PGXS  (Fabien COELHO <coelho@cri.ensmp.fr>)
Re: Frustrating issue with PGXS  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Fabien COELHO <fabien.coelho@ensmp.fr> writes:
> But ISTM that the remedy (breaking all past makefiles for all extensions) 
> is not worth the issue.
> A better documentation, and possibly following your suggestion with an 
> explicit PG_CONFIG in contrib makefiles, but without breaking existing 
> extensions seems quite enough. The error made by Eddie is legitimate, but
> it is also something rare, it did not come up in the last two years.

True.  OK, then let's add the ifndef to Makefile.global and change the
existing extension makefiles to
PG_CONFIG := pg_configPGXS := $(shell $(PG_CONFIG) --pgxs)include $(PGXS)

Any objections?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Chris Mair
Date:
Subject: no cascade triggers?
Next
From: Gregory Stark
Date:
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords