Re: autovacuum multiworkers, patch 5 - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: autovacuum multiworkers, patch 5
Date
Msg-id 20070412124251.GA5783@alvh.no-ip.org
Whole thread Raw
In response to Re: autovacuum multiworkers, patch 5  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: autovacuum multiworkers, patch 5
List pgsql-patches
ITAGAKI Takahiro wrote:
>
> Alvaro Herrera <alvherre@commandprompt.com> wrote:
>
> > > > I manually merged your patch on top of my own.  This is the result.
> > > > Please have a look at whether the new code is correct and behaves sanely
> > > > (I haven't tested it).
> >
> > Huh, you are right, it is broken, even in my outgoing mailbox -- I don't
> > know what happened, as the file I have on disk is complete.  Here is
> > attached again.
>
> I tested your patch on Linux and Windows. It works well on Linux,
> where we use fork(), but falls into segfault on Windows, where we
> use exec(). Maybe you forgot to initialize the shared memory stuff.
> (I haven't find out where to be fixed, sorry.)

Ok, thanks, this confirms that I have to try the EXEC_BACKEND code path.

> Multiworker and balancing seem to work well after they successfully start up.

Great.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-patches by date:

Previous
From: "Marko Kreen"
Date:
Subject: Re: RESET SESSION v3
Next
From: "Gurjeet Singh"
Date:
Subject: Re: [HACKERS] [Fwd: Index Advisor]