Re: Fast CLUSTER - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Fast CLUSTER
Date
Msg-id 200703271428.l2RESs016552@momjian.us
Whole thread Raw
In response to Re: Fast CLUSTER  ("Simon Riggs" <simon@2ndquadrant.com>)
Responses Re: Fast CLUSTER
List pgsql-patches
Simon Riggs wrote:
> On Thu, 2007-02-22 at 22:49 +0000, Simon Riggs wrote:
> > On Tue, 2007-02-20 at 14:38 -0300, Alvaro Herrera wrote:
> >
> > > Cool.  I noticed that the SGML seems broken here:
> >
> > Corrected.
> >
> > > You need to close the <listitem> and <para> opened in the COPY mention.
> > >
> > > > +
> > > > + static void
> > > > + heap_sync_relation(Relation rel)
> > > > + {
> > > > +     if (!rel->rd_istemp)
> > >
> > > No comment in this function?
> >
> > I've added more comments as you suggest.
> >
> > Thanks for the review.
>
> Could we add this to the unapplied patches queue? It seems to have been
> missed off the list. Thanks.

Done.

--
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Improvement of procArray.xmin for VACUUM
Next
From: Bruce Momjian
Date:
Subject: Re: Fast CLUSTER