Re: cosmetic patch to large object regression test - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: cosmetic patch to large object regression test
Date
Msg-id 200703032017.l23KHaF16407@momjian.us
Whole thread Raw
In response to cosmetic patch to large object regression test  (Jeremy Drake <pgsql@jdrake.com>)
Responses Re: cosmetic patch to large object regression test
List pgsql-patches
Patch applied.  Thanks.

---------------------------------------------------------------------------


Jeremy Drake wrote:
> Since I have now learned that it is possible to input values in hex in
> postgres, I submit this patch to clean up the ugly workaround I did in the
> largeobject regression test to try to input hex values.  It does not
> change the functionality of the test at all, it just makes it more
> readable.
>
> In detail, before when I needed to write hex values, for example
> 0x20000 | 0x40000,
> for the flags to lo_open, I would write it:
> CAST((2 | 4) * 16^4 AS integer)
>
> Now, I write it:
> CAST(x'20000' | x'40000' AS integer)
>
> which is more like the C and other language consumers of the API, and also
> is more obvious what I am trying to do, IMHO.
>
>
> --
> Real Programs don't use shared text.  Otherwise, how can they use
> functions for scratch space after they are finished calling them?
Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faq

--
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Split _bt_insertonpg to two functions
Next
From: Jeremy Drake
Date:
Subject: Re: cosmetic patch to large object regression test