Re: tsearch in core patch, for inclusion - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: tsearch in core patch, for inclusion
Date
Msg-id 200702202221.l1KMLlK14454@momjian.us
Whole thread Raw
In response to Re: tsearch in core patch, for inclusion  (Oleg Bartunov <oleg@sai.msu.su>)
Responses Re: tsearch in core patch, for inclusion
List pgsql-hackers
Oleg Bartunov wrote:
> On Tue, 20 Feb 2007, Alvaro Herrera wrote:
> 
> > Bruce Momjian wrote:
> >>
> >> FYI, I added this to the patches queue because I think we decided
> >> full-text indexing should be in the core.  If I am wrong, please let me
> >> know.
> >
> > One of the objections I remember to this particular implementation was
> > that configuration should be done using functions rather than new syntax
> > in gram.y.  This seems a good idea because it avoids bloating the
> > grammar, while still allowing dependency tracking, pg_dump support,
> > syscache support etc.
> 
> It's not so big addition to the gram.y, see a list of commands
> http://mira.sai.msu.su/~megera/pgsql/ftsdoc/sql-commands.html.
> SQL commands make FTS syntax clear and follow tradition to manage
> system objects. From the user's side, I'd be very unhappy to configure
> FTS, which can be very complex, using functions.  All we want is to 
> provide users clear syntax.

I looked at the diff file and the major change in gram.y is the creation
of a new object type FULLTEXT, so you can CREATE, ALTER and DROP
FULLTEXT.

I don't know fulltext administration well enough, so if Oleg says a
function API would be too complex, I am OK with his new parser syntax.

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Oleg Bartunov
Date:
Subject: Re: tsearch in core patch, for inclusion
Next
From: Bruce Momjian
Date:
Subject: Re: DROP FUNCTION failure: cache lookup failed for relation X