Re: unixware and --with-ldap - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: unixware and --with-ldap
Date
Msg-id 200702030246.l132k4608947@momjian.us
Whole thread Raw
In response to Re: unixware and --with-ldap  ("Albe Laurenz" <all@adv.magwien.gv.at>)
List pgsql-hackers
Clarification, this is the email used to make the patch that was
backpatched.

---------------------------------------------------------------------------

Albe Laurenz wrote:
> >>> I have tried --with-thread-safety and configure fails on ldap check
> >>> because for some reason CTHREAD_FLAGS (-Kpthread for UW) is missing
> >>> on compile command, although present before that. I can't find why
> >>
> >> You mean PTHREAD_FLAGS, right?
> >>
> > Nope,I mean PTHREAD_CFLAGS witch is defined in src/templates/unixware
> 
> PTHREAD_CFLAGS, of course :^)
> 
> Oops, this seems to be an oversight in (my) original code.
> 
> I'd say we should change the lines
> 
>   AC_CHECK_LIB(ldap_r, ldap_simple_bind, [],
>       [AC_MSG_ERROR([library 'ldap_r' is required for LDAP])],
>       [$PTHREAD_LIBS $EXTRA_LDAP_LIBS])
> 
> to
> 
>   AC_CHECK_LIB(ldap_r, ldap_simple_bind, [],
>       [AC_MSG_ERROR([library 'ldap_r' is required for LDAP])],
>       [$PTHREAD_CFLAGS $PTHREAD_LIBS $EXTRA_LDAP_LIBS])
> 
> I know that this is abuse of AC_CHECK_LIB, but it is only a test
> and LIBS is discarded later.
> 
> Yours,
> Laurenz Albe
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Dirty pages in freelist cause WAL stuck
Next
From: Kate F
Date:
Subject: snprintf()