Re: [HACKERS] Win32 WEXITSTATUS too - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: [HACKERS] Win32 WEXITSTATUS too
Date
Msg-id 20070123150743.GA16185@svr2.hagander.net
Whole thread Raw
In response to Re: [HACKERS] Win32 WEXITSTATUS too  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [HACKERS] Win32 WEXITSTATUS too  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
On Tue, Jan 23, 2007 at 09:29:19AM -0500, Bruce Momjian wrote:
> Magnus Hagander wrote:
> > On Tue, Jan 23, 2007 at 06:50:06PM +0900, Takayuki Tsunakawa wrote:
> > > From: "Magnus Hagander" <magnus@hagander.net>
> > > > Are you entirely sure that ntstatus.h is where to look? Because per
> > > > whatever docs I've found, that contains "device driver errors" and
> > > *not*
> > > > exception codes.
> > >
> > > Yes, what you are pointing out is correct.  winbase.h and winnt.h
> > > should be consulted instead of ntstatus.h.  See the the section
> > > "Return Value" in the following page:
> > >
> > > http://msdn2.microsoft.com/ru-ru/library/ms679356.aspx
> > >
> > > Furthermore, the message is meaningless for users because they can do
> > > nothing with the information.  So, I think the message should say
> > > something like
> > >
> > > child process was terminated by exception %X
> > > This seems to be a bug of PostgreSQL.
> > > Please report this message with the details of the phynomenon to
> > > PostgreSQL developers.
> > >
> > >
> > > What do you think?
> >
> > I think that's incorrect information to the user :-(
> > If the child terminates with exit(1), we will then say "child process
> > was terminated by exception 1. This seems to be a bug", which is clearly
> > not true.
> >
> > Unless you know a sure way of determining if the exitcode is a normal
> > exitcode or an exception code.
>
> Current CVS believes values >= 0x100 are non-exit() terminations.

Why does it do that :-) That's clearly wrong. There are plenty of
exitcodes > 0x100 that aren't exceptions.

//Magnus

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Win32 WEXITSTATUS too
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Win32 WEXITSTATUS too