Re: [PATCHES] [COMMITTERS] pgsql: Change FETCH/MOVE - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] [COMMITTERS] pgsql: Change FETCH/MOVE
Date
Msg-id 200609030324.k833Oet24439@momjian.us
Whole thread Raw
In response to Re: [PATCHES] [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> >> This patch has broken half the buildfarm, and I've still not seen a
> >> rationale why we need to make such a change at all.
>
> > Fixed with attached patch.  The use case for this was not FETCH, but
> > MOVE for > 2gig tables.
>
> There is *no* credible use case for this (hint: MOVE FORWARD/BACKWARD
> ALL does not need this to work for >2G tables).  It is not worth the
> extra computational cycles that it imposes on every machine whether they
> use the feature or not, and it is certainly not worth the developer time
> we're expending to fix this poorly written patch.  Please revert it.

Already done because of bad coding.  You want the TODO item removed too?

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.
Next
From: "Joshua D. Drake"
Date:
Subject: Re: gBorg status?