Re: [PATCHES] Allow commenting of variables in postgresql.conf to - try 4 - Mailing list pgsql-hackers

From Joachim Wieland
Subject Re: [PATCHES] Allow commenting of variables in postgresql.conf to - try 4
Date
Msg-id 20060724174758.GB2053@mcknight.de
Whole thread Raw
In response to Re: [PATCHES] Allow commenting of variables in postgresql.conf to - try 4  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On Mon, Jul 24, 2006 at 10:55:47AM -0400, Stephen Frost wrote:
> #2: That variable can *not* be changed by a reload.
>     Notice-level message is sent to the log notifying the admin that the
>     change requested could not be performed.  This change could be
>     either a revert to reset-value if it was removed/commented-out or an
>     explicit change request to a different value.

Right. And what I am voting for is to not only issue such a message once but
every time a SIGHUP is received as long as the actively-used value differs
from the value in the configuration file. One of the reasons for having this
fall-back-to-default-value stuff is to make sure that an admin can restart a
server and be sure that it will behave in the same way as when it was
shut down.

Moreover it's just clearer to send the notice message every time a SIGHUP is
received since every reload is the admin's request to apply all of the
values in the configuration file independently of what has happened in the
past.


Joachim


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: plPHP and plRuby
Next
From: "Joshua D. Drake"
Date:
Subject: Re: plPHP and plRuby