Re: Patch to mark items as static or not used - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: Patch to mark items as static or not used
Date
Msg-id 20060715151807.GA2467@svana.org
Whole thread Raw
In response to Re: Patch to mark items as static or not used  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Sat, Jul 15, 2006 at 09:34:57AM -0400, Andrew Dunstan wrote:
> Neil Conway wrote:
> >We could annotate the source to indicate that some functions are
> >deliberately intended to be externally visible, but not referenced
> >within the source tree, and then teach find_static to grok that
> >annotation.
>
> I thought of that, but what if one gets missed? Is the tool worth the
> hassle?

The tool is just a tool. The annotation is so that some human won't
come to the conclusion that it can be removed. Teaching the tool to
skip it is just a bonus.

Some places mark external functions with DLLEXPORT but I guess we could
invent a comment that would be machine readable.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Patch to mark items as static or not used
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] [patch 0/9] annual pgcrypto update