Re: Instability in TRUNCATE regression test - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Instability in TRUNCATE regression test
Date
Msg-id 20060628175609.GC30996@surnet.cl
Whole thread Raw
In response to Re: Instability in TRUNCATE regression test  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera wrote:
> Tom Lane wrote:
> > Alvaro Herrera <alvherre@commandprompt.com> writes:
> > > Tom Lane wrote:
> > >> 1. Find a way to make the processing order consistent (eg by driving it
> > >> off OID ordering).  Doesn't seem easy, but maybe I'm missing an idea.
> > 
> > > Hmm, what about
> > 
> > > 1. get the complete list of tables to truncate, AccessShareLock'ed, get
> > > their names
> > > 2. release locks
> > > 3. sort the list lexicographically (or by Oid, whatever)
> > > 4. acquire the stronger locks, in list order, taking care of not
> > > aborting if a table is no longer there
> > > 5. truncate
> > 
> > Releasing locks is no good ... what if someone adds/drops FK constraints
> > while you've not got any lock?
> 
> Recheck after acquiring the stronger locks, unlock and drop from list.

Oops, this doesn't cover the "add FK constraints" case, only drop.  I
think it would work to keep the locks on the tables initially mentioned
in the command (i.e. those not followed by CASCADE).  Hmm, but it fails
if it cascades more than once, so scratch that.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Fixed length datatypes. WAS [GENERAL] UUID's as
Next
From: Tom Lane
Date:
Subject: Re: Instability in TRUNCATE regression test