Re: pgsql: Prevent certain symbols that are used for both - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Prevent certain symbols that are used for both
Date
Msg-id 200511151509.jAFF9qF13020@candle.pha.pa.us
Whole thread Raw
In response to Re: pgsql: Prevent certain symbols that are used for both typedefs and  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> momjian@svr1.postgresql.org (Bruce Momjian) writes:
> > Prevent certain symbols that are used for both typedefs and variable
> > names from being added to pgindent's typedef list.  The existance of
> > them caused weird formatting in the date/type files, and in keywords.c.
>
> Maybe it would be better to do some judicious renaming in the sources
> to avoid the conflicts?  ISTM that failing to mark a typedef as such
> will inevitably result in bad formatting of code that uses the name
> as a typedef.

Yea, but I don't want to do anything like that now, especially since
most of the date/time typedefs are used by ecpg and I am unsure what
affect changing those might have.

My logic was that is was better to have ecpg unclearly typedef'ed in a
few places than to have an adt/ file show "interval    ->days".  "ANY"
is coming from plperl but I can't see from where.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Prevent certain symbols that are used for both typedefs and
Next
From: gsmet@pgfoundry.org (User Gsmet)
Date:
Subject: pgfouine - pgfouine: text reports refactoring + added html report to