BUG #1936: Read-only transactions ignored in COPY - Mailing list pgsql-bugs

From Alon Goldshuv
Subject BUG #1936: Read-only transactions ignored in COPY
Date
Msg-id 20051003215344.6DD8BF11F5@svr2.postgresql.org
Whole thread Raw
List pgsql-bugs
The following bug has been logged online:

Bug reference:      1936
Logged by:          Alon Goldshuv
Email address:      agoldshuv@greenplum.com
PostgreSQL version: 8 (Current Dev)
Operating system:   any
Description:        Read-only transactions ignored in COPY
Details:

In the folllowing check (copy.c:DoCopy() ), i *think* that the check for the
is_from flag is mistakenly negated. is_from means -> from file to database,
therefore we should check for <XactReadOnly && is_from>, and not
<XactReadOnly && !is_from>

/* check read-only transaction */
if (XactReadOnly && !is_from &&
    !isTempNamespace(RelationGetNamespace(cstate->rel)))
    ereport(ERROR,
            (errcode(ERRCODE_READ_ONLY_SQL_TRANSACTION),
             errmsg("transaction is read-only")));

pgsql-bugs by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Bug?: Text after right paren in query is ignored
Next
From: Kouber Saparev
Date:
Subject: Re: BUG #1927: incorrect timestamp returned