Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > This needs to be applied soon so the installer can be tested.
>
> I can't speak to the details of the Windows process-launch code,
> but it looked okay to me otherwise.
>
> One point: if I understood correctly, this is necessary only for
> Windows 2000, because we've already blown off the thought of
> supporting any older Windows versions, no? If we later decide
> we can't support W2K either, this would be a pretty large chunk
> of code that we could pull out. Please make sure it's clearly
> labeled as "useful only as long as we support Windows 2000".
Yep, I had him add this comment:
+ * The runtime librarys popen() on win32 does not work when being
+ * called from a service when running on windows <= 2000, because
+ * there is no stdin/stdout/stderr.
I think we support NT too, hence the <= 2000.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
