Re: pg_ctl reports succes when start fails - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_ctl reports succes when start fails
Date
Msg-id 200310231651.h9NGpAR26616@candle.pha.pa.us
Whole thread Raw
In response to Re: pg_ctl reports succes when start fails  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Tommi Maekitalo <t.maekitalo@epgmbh.de> writes:
> > I installed 7.4beta5, created a data-dir and tried to start postgresql with
> > pg_ctl without initdb. As expected, this will fail. But pg_ctl tells me
> > "postmaster successfully started", after a fatal error, which looks very
> > confusing. When I use -l for specifying a logfile, I don't even see the
> > error, but only the success-message.
>
> If you don't use -w, then pg_ctl doesn't wait around to see whether the
> postmaster started or not.  It'd probably be a good idea for it to issue
> a less positive message in this case, maybe only "postmaster launched".
>
> I also wonder why -w isn't the default.

The following patch changes the message from "started" to "starting" for
non-"-w" starts.  I will keep it for 7.5.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/bin/pg_ctl/pg_ctl.sh
===================================================================
RCS file: /cvsroot/pgsql-server/src/bin/pg_ctl/pg_ctl.sh,v
retrieving revision 1.36
diff -c -c -r1.36 pg_ctl.sh
*** src/bin/pg_ctl/pg_ctl.sh    14 Aug 2003 18:56:41 -0000    1.36
--- src/bin/pg_ctl/pg_ctl.sh    23 Oct 2003 16:49:56 -0000
***************
*** 399,406 ****
          fi
      done
      $silence_echo echo "done"
      fi
-     $silence_echo echo "postmaster successfully started"
  fi # start or restart

  exit 0
--- 399,408 ----
          fi
      done
      $silence_echo echo "done"
+     $silence_echo echo "postmaster successfully started"
+     else
+     $silence_echo echo "postmaster starting"
      fi
  fi # start or restart

  exit 0

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_ctl reports succes when start fails
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_ctl reports succes when start fails