Re: PQescapeBytea on Win32 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: PQescapeBytea on Win32
Date
Msg-id 200303221854.h2MIsID29300@candle.pha.pa.us
Whole thread Raw
In response to Re: PQescapeBytea on Win32  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > Tom Lane wrote:
> > >> Doesn't this duplicate a function that we already invented for PQnotify
> > >> structs?
> > 
> > > What do you recommend?  Do we depricate PQfreeNotify?
> > 
> > I dunno.  In hindsight it was shortsightedly named.  But I don't suppose
> > we want to tell people to use "PQfreeNotify" to free the result of
> > PQescapeBytea ... so deprecation seems to be the order of the day.
> > 
> > Do we really want "PQfreemem" either?  Maybe it should be "PQfree"?
> 
> I am a little concerned that PQfree would be confused with PQclear.
> 
> Could we have PQfreeNotify() be a macro to PQfreemem in 7.4?

The only place I see PQfreeNotify() used in our code is libpgtcl, aside
from libpq, and a macro would work fine.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PQescapeBytea on Win32
Next
From: Tom Lane
Date:
Subject: Re: PQescapeBytea on Win32