Re: (yet) more buffer paranoia - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: (yet) more buffer paranoia
Date
Msg-id 200208281906.g7SJ6lg04163@candle.pha.pa.us
Whole thread Raw
In response to Re: (yet) more buffer paranoia  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
Peter Eisentraut wrote:
> Neil Conway writes:
>
> > This patches replaces a few more usages of strcpy() and sprintf() when
> > copying into a fixed-size buffer (in this case, a buffer of
> > NAMEDATALEN bytes). AFAICT nothing to worry about here, but worth
> > fixing anyway...
>
> Changing strcpy to strncpy is incorrect.  strncpy should be banned.

Good point.  Maybe StrNCpy, which is our standard strncpy().

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Proposed GUC Variable
Next
From: Larry Rosenman
Date:
Subject: Re: [HACKERS] Proposed GUC Variable