Re: pg_stat_reset round 3 - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: pg_stat_reset round 3
Date
Msg-id 200208060602.g76626f12672@candle.pha.pa.us
Whole thread Raw
In response to pg_stat_reset round 3  ("Christopher Kings-Lynne" <chriskl@familyhealth.com.au>)
Responses Re: pg_stat_reset round 3
List pgsql-patches
Interesting that all callable function must return a type.  I did:

    test=> select proname from pg_proc where prorettype = 0;

and none of the functions with 0 prorettype can be called from psql.  I
guess boolean is the best we can do.  I guess because it is a function
it has to return something.


---------------------------------------------------------------------------

Christopher Kings-Lynne wrote:
> OK, I've attached a new patch where the function is marked volatile.  I
> tested and you cannot have the function returning void, so I left it
> returning boolean.
>
> Chris
>
> > -----Original Message-----
> > From: pgsql-patches-owner@postgresql.org
> > [mailto:pgsql-patches-owner@postgresql.org]On Behalf Of Christopher
> > Kings-Lynne
> > Sent: Monday, 5 August 2002 4:00 PM
> > To: Neil Conway
> > Cc: Patches
> > Subject: Re: [PATCHES] pg_stat_reset round 2
> >
> >
> > > It should be marked volatile (rather than stable), as it has
> > > side-effects.
> >
> > OK, I'll fix it.
> >
> > > Wouldn't PG_RETURN_VOID() be more appropriate than returning true?
> >
> > I was under the impression that functions used in SELECTs cannot use
> > PG_RETURN_VOID()...
> >
> > Chris
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 5: Have you checked our extensive FAQ?
> >
> > http://www.postgresql.org/users-lounge/docs/faq.html
> >

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: anonymous composite types for Table Functions (aka
Next
From: Bruce Momjian
Date:
Subject: Re: pg_stat_reset round 3