Re: [SQL] pg_restore cannot restore function - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [SQL] pg_restore cannot restore function
Date
Msg-id 200207040536.g645a9301288@candle.pha.pa.us
Whole thread Raw
In response to Re: [SQL] pg_restore cannot restore function  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > The following patch fixes all of these, and it will be in 7.3.
>
> It will?  Kindly explain what the heck this is doing.  It looks to
> me like it will probably break more cases than it fixes.  AFAICS
> it's just completely muddying the waters about what is quoted and
> what isn't ...

Well, the waters were already muddy.  Doing a pg_dump -Ft, you will see
with the old code how the tags for functions had quotes, and how the
GRANT/REVOKE has quotes for table names, while the CREATE TABLE tags for
these do not.  This fixes that, and tries to get the -P string they
enter for pg_restore to match the tag by removing spaces.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026



pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [SQL] pg_restore cannot restore function
Next
From: "Dave Page"
Date:
Subject: Re: [ODBC] UI patch (Was: ODBC Patch to prevent setting of KSQO on 7.3+ servers)