Re: regression tests for ALTER TABLE ... DEFAULT - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: regression tests for ALTER TABLE ... DEFAULT
Date
Msg-id 200204240428.g3O4S1203396@candle.pha.pa.us
Whole thread Raw
In response to Re: regression tests for ALTER TABLE ... DEFAULT  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: regression tests for ALTER TABLE ... DEFAULT  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > Peter Eisentraut wrote:
> > > Neil Conway writes:
> > >
> > > > The attached patch adds regression tests for setting and removing
> > > > default values using ALTER TABLE, on both views and tables.
> > >
> > > Regression tests tend to be more useful if they are added to the list of
> > > tests to run during 'make check'.
> >
> > I am seeing regression failures and am working on those now.
>
> Don't you ever run the tests before checking stuff in?

Nope.  I do it once a batch is checked in.  I assume submitters have
already done it.  Too much work.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: regression tests for ALTER TABLE ... DEFAULT
Next
From: Tom Lane
Date:
Subject: Re: unknownin/out patch (was [HACKERS] PQescapeBytea is not