Re: Commands/ directory reorganisation - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Commands/ directory reorganisation
Date
Msg-id 200204142337.g3ENbN514470@candle.pha.pa.us
Whole thread Raw
In response to Commands/ directory reorganisation  (John Gray <jgray@azuli.co.uk>)
Responses Re: Commands/ directory reorganisation  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
OK, what time timeframe are we in for application of this patch?  If I
get OK from a few people in the next few hours, do I apply so the code
doesn't drift?


---------------------------------------------------------------------------

John Gray wrote:
> Dear all,
>
> Patch attached in line with my previous statement on -hackers about
> reorganisation of files in the commands directory. (Note that define.c
> has been kept, holding some of the common support code for define
> routines.)
>
> I have checked this and it compiles and passes regression tests. It is
> just straightforward moving of code from one place to another.
>
> I will have to be out until ~1700 UTC Monday -at which point I will be
> happy to answer any questions which arise.
>
> Regards
>
> John
>
>
> Notes to Committer
> ------------------
>
> The following files are removed in this patch:
>
> src/backend/commands/command.c
> src/backend/commands/creatinh.c
> src/backend/commands/remove.c
> src/backend/commands/rename.c
> src/include/commands/command.h
> src/include/commands/creatinh.h
> src/include/commands/rename.h
>
> The following files are added:
>
> src/backend/commands/aggregatecmds.c
> src/backend/commands/domaincmds.c
> src/backend/commands/functioncmds.c
> src/backend/commands/lockcmds.c
> src/backend/commands/operatorcmds.c
> src/backend/commands/portalcmds.c
> src/backend/commands/schemacmds.c
> src/backend/commands/tablecmds.c
> src/backend/commands/typecmds.c
>
> src/include/commands/lockcmds.h
> src/include/commands/portalcmds.h
> src/include/commands/schemacmds.h
> src/include/commands/tablecmds.h
>
>
> Details for commit message:
>
> The contents of command.c, creatinh.c, define.c, remove.c and rename.c
> have been divided according to the type of object manipulated -so ALTER
> TABLE code is in tablecmds.c, aggregate commands in aggregatecmds.c and
> so on.
>
> A few support routines remain in define.c (prototypes in
> src/include/commands/defrem.h
>
> No code has been changed except for includes to reflect the new files.
> The prototypes for aggregatecmds.c, domaincmds.c, functioncmds.c,
> operatorcmds.c, and typecmds.c remain in src/include/commands/defrem.h
>
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: John Gray
Date:
Subject: Commands/ directory reorganisation
Next
From: Tom Lane
Date:
Subject: Re: BETWEEN Help