On Tuesday 12 March 2002 00:34, Peter Eisentraut wrote:
> Ian Barwick writes:
> > So with no further ado I humbly submit the attached patch, which builds
> > on your patch and tidies up / harmonises the \? output.
>
> That looks a lot better. A few things, though:
>
> The change to \a seems to be wrong-headed.
What do you mean by "wrong-headed"?
That it should read "toggle aligned output mode" ?
(Would be more logical).
> The line for \du speaks of "configured" users. There are no
> "unconfigured" users.
That line was from the patch by Rod Taylor (March 1, 2002). Didn't think
to change it. Does "list users" do the job? BTW psql-ref.sgml also
says "Lists all configured users (...)"
> \set should be \set [NAME [VALUE]], or strictly speaking even \set [NAME
> [VALUE [...]]].
True. I actually started out with:
\set [NAME [STRING]] set internal variable (no name: list all; no string: '')
which is (almost) accurate but verbose.
> Some lines seem to be in excess of 80 characters.
Longest line is 74 columns (or 77 with the \set line above).
> I guess some of these weren't introduces by you, but if someone is going
> to fix this, he might as well take care of these.
Will submit another patch in the morning (it's late here).
Ian Barwick
