Re: [BUGS] COPY FROM is not 8bit clean - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [BUGS] COPY FROM is not 8bit clean
Date
Msg-id 200202270309.g1R39Wp03556@candle.pha.pa.us
Whole thread Raw
In response to Re: [BUGS] COPY FROM is not 8bit clean  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Can someone explain why this fixes the problem.
> 
> Think about a machine where char is signed by default.  Extracting \254
> into an int will produce -2, which will not equal \254 returned by getc.

Oh, I thought that the int returned by getc already had that sign
extension, but now I remember it doesn't.  In fact, it specifically
returns an int so -1 can be identified.  Got it.  Seems I am forgetting
some of my C.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Justin Clift
Date:
Subject: Experimental Feature development in PostgreSQL
Next
From: Bruce Momjian
Date:
Subject: Re: Refactoring of command.c