Re: [JDBC] Attempt to clean up ExecSql() in JDBC - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [JDBC] Attempt to clean up ExecSql() in JDBC
Date
Msg-id 200108281615.f7SGFeq28851@candle.pha.pa.us
Whole thread Raw
In response to Attempt to clean up ExecSql() in JDBC  (Anders Bengtsson <ndrsbngtssn@yahoo.se>)
List pgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

>
> Hi,
>
> Attached is my attempt to clean up the horrors of the ExecSQL() method in
> the JDBC driver.
>
> I've done this by extracting it into a new method object called
> QueryExecutor (should go into org/postgresql/core/) and then taking it
> apart into different methods in that class.
>
> A short summary:
>
> * Extracted ExecSQL() from Connection into a method object called
>   QueryExecutor.
>
> * Moved ReceiveFields() from Connection to QueryExecutor.
>
> * Extracted parts of the original ExecSQL() method body into smaller
>   methods on QueryExecutor.
>
> * Bug fix: The instance variable "pid" in Connection was used in two
>   places with different meaning. Both were probably in dead code, but it's
>   fixed anyway.
>
> /Anders
>
>
> PS.: If anyone has any idea what the variable names "fqp" and "hfr" stand
> for, please tell me! :)
>
> _____________________________________________________________________
> A n d e r s  B e n g t s s o n                   ndrsbngtssn@yahoo.se
> Stockholm, Sweden

Content-Description:

[ Attachment, skipping... ]

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Barry Lind
Date:
Subject: Re: JDBC Statement.executeBatch patch
Next
From: Peter Eisentraut
Date:
Subject: Re: PAM Authentication Patch, take one...