Re: encoding names - Mailing list pgsql-patches

From Tatsuo Ishii
Subject Re: encoding names
Date
Msg-id 20010823095506U.t-ishii@sra.co.jp
Whole thread Raw
In response to Re: encoding names  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
> Tatsuo Ishii writes:
>
> > I don't think you need to change the function name "getdbencoding".
> > "get_canonical_database_encoding" is too long anyway.
>
> But getdbencoding isn't semantically different from the old
> getdatabaseencoding.  "encoding" isn't the right term anyway, methinks, it
> should be "character set".  So maybe database_character_set()?  (No "get"
> please.)

I'm not a native English speaker, so please feel free to choose more
appropriate name.

BTW, what's wrong with "encoding"? I don't think, for example EUC-JP
or utf-8, are character set names.
--
Tatsuo Ishii

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: encoding names v2.
Next
From: Tatsuo Ishii
Date:
Subject: Re: encoding names v2.