Re: Re: [PATCH] Cleanup of JDBC character encoding - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Re: [PATCH] Cleanup of JDBC character encoding
Date
Msg-id 200107122012.f6CKCiJ28212@candle.pha.pa.us
Whole thread Raw
In response to Re: [PATCH] Cleanup of JDBC character encoding  (Anders Bengtsson <ndrsbngtssn@yahoo.se>)
List pgsql-patches
Here is the right one:

Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

> On Mon, 9 Jul 2001, Barry Lind wrote:
>
> > Anders,
> >
> > I have some issues with this patch.
> >
> > 1) Please don't require the driver to perform yet another round trip to
> > the server to get the database encoding.  You changed the following code
> > which accessed the server once at connection creation:
> [snip]
> > 2) I don't like having test specific code in Encoding.java, specifically
> > the dummy encoding 'X-UNIT-TESTS'.
>
> Thanks Barry, I'll fix these things and return with a new patch.
>
> I think I'll be able to get pretty good test coverage even without the
> extra test data.
>
> /Anders
> _____________________________________________________________________
> A n d e r s  B e n g t s s o n                   ndrsbngtssn@yahoo.se
> Stockholm, Sweden
>
>
> _________________________________________________________
> Do You Yahoo!?
> Get your free @yahoo.com address at http://mail.yahoo.com
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [JDBC] Re: Re: [PATCH] Cleanup of JDBC character encoding
Next
From: Bruce Momjian
Date:
Subject: Re: [JDBC] [PATCH] Cleanup of JDBC character encoding