Re: Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding - Mailing list pgsql-jdbc

From Bruce Momjian
Subject Re: Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding
Date
Msg-id 200107122034.f6CKYxB29367@candle.pha.pa.us
Whole thread Raw
In response to Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding  (Anders Bengtsson <ndrsbngtssn@yahoo.se>)
List pgsql-jdbc
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

>
> > > I have some issues with this patch.
> > >
> > > 1) Please don't require the driver to perform yet another round trip to
> > > the server to get the database encoding.  You changed the following code
> > > which accessed the server once at connection creation:
> > [snip]
> > > 2) I don't like having test specific code in Encoding.java, specifically
> > > the dummy encoding 'X-UNIT-TESTS'.
>
> Ok, now I've made the changes, and added a comment about why the code for
> (1) should stay optimized. :)
>
> /Anders
> _____________________________________________________________________
> A n d e r s  B e n g t s s o n                   ndrsbngtssn@yahoo.se
> Stockholm, Sweden

Content-Description:

[ Attachment, skipping... ]

Content-Description:

[ Attachment, skipping... ]

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-jdbc by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: To do list for DatabaseMetaData
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCH] Cleanup of JDBC character encoding