Re: [PORTS] Re: patch for minor Win32 makefile bug - Mailing list pgsql-patches

From Jason Tishler
Subject Re: [PORTS] Re: patch for minor Win32 makefile bug
Date
Msg-id 20010404171455.A802@dothill.com
Whole thread Raw
In response to Re: [PORTS] Re: patch for minor Win32 makefile bug  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom,
Peter,

On Wed, Apr 04, 2001 at 05:04:40PM -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > It seems we're now down to
>
> > DLLLIBS= -lcygipc -lcrypt
>
> > but I think it can be removed completely.
>
> > We have three uses of this variable:
>
> > 1) Makefile.win, for building extension modules.  No module in existance
> > needs -lcygipc, and if one needs -lcrypt it can put it into SHLIB_LINK.
>
> > 2) Makefile.shlib, see 1)
>
> > 3) -lcrypt already comes in via LIBS (like all the other libraries),
> > -lcygipc can do the same, or be hard-coded in place.
>
>
> But you forgot about -lpostgres for the backend libraries (plpgsql etc).
>
> I suppose that we might consider adding these libraries to LIBS not
> DLLLIBS, but that's cleanup work that I'd rather not try to do under
> time pressure (especially since I can't test it here).

Can we commit my updated patch for 7.1RC3?  I promise to help clean up
the above for RC4 or final.  Is this acceptable?

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Next
From: Jason Tishler
Date:
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug