Re: Re: Patch application - Mailing list pgsql-hackers
From | Bruce Momjian |
---|---|
Subject | Re: Re: Patch application |
Date | |
Msg-id | 200103202214.RAA24216@candle.pha.pa.us Whole thread Raw |
In response to | Re: Re: Patch application (Philip Warner <pjw@rhyme.com.au>) |
List | pgsql-hackers |
OK, seems there have been enough objections that I will not implement a "experts" page, nor change the way patches are applied. I will be posting a diff -c of any patches I have to munge into place, so people can see how stuff was merged into the code. It seems the problem of people having to massage patches after they are applied is either not a big deal, or the other ways of applying patches are considered worse. > At 05:36 20/03/01 +0000, Thomas Lockhart wrote: > > > >Unless there is a "process improvement" which comes with developing this > >list, I don't really see what the benefit will be wrt existance of the > >list, developing the list, of deciding who should be on a list, etc etc. > > > > Totally agree; such formality will be barrier and we will gain almost > nothing. It will also further disenfranchise the wider developer community. > ISTM that the motivation is based on one or two isolated incidents where > patches were applied when they should not have been. Tom's suggestion of > insisting on CVS headers will deal with the specific case in point, at far > lesser social and labour overhead. > > The last thing we want to do to people who contribute heavily to the > project is say 'Gee, thanks. And you are now responsible for all approvals > on this area of code', especially in late beta, when they are likely to be > quite busy. Similarly, when we are outside the beta phase, we don't need > the process. > > I suspect that anybody who has worked on a chunk of code in a release cycle > will keep an eye on what is happening to the code. > > My suggestion for handling this process would be to allow an opt-in 'watch' > to be placed on files/modules in CVS (CVS supports this, from memory). > Then, eg, I can say 'send me info when someone makes a match to pg_dump'. > Similarly, when I start working on a module, I can add myself to the list > to be informed when someone changes it underneath me. This would be > genuinely useful to me as a part-time developer. > > As a further development from this, it would be good to see a way for bug > reports to be redirected to 'subsystems' (or something like that), which > developers could opt into. So, using myself as an example, I would like > special notification when a pg_dump bug is reported. Similarly, I might > like to be notified when changes are made to the WAL code... > > If you want to make cute web pages, and define domain experts, make it > useful, make it opt-in, and make it dynamic. > > > ---------------------------------------------------------------- > Philip Warner | __---_____ > Albatross Consulting Pty. Ltd. |----/ - \ > (A.B.N. 75 008 659 498) | /(@) ______---_ > Tel: (+61) 0500 83 82 81 | _________ \ > Fax: (+61) 0500 83 82 82 | ___________ | > Http://www.rhyme.com.au | / \| > | --________-- > PGP key available upon request, | / > and from pgp5.ai.mit.edu:11371 |/ > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Don't 'kill -9' the postmaster > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
pgsql-hackers by date: