Re: add queryEnv to ExplainOneQuery_hook - Mailing list pgsql-hackers

From Tatsuro Yamada
Subject Re: add queryEnv to ExplainOneQuery_hook
Date
Msg-id 1ee489eb-7545-e227-3a7f-0804424fd3aa@lab.ntt.co.jp
Whole thread Raw
In response to Re: add queryEnv to ExplainOneQuery_hook  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2018/01/12 2:02, Tom Lane wrote:
> Thomas Munro <thomas.munro@enterprisedb.com> writes:
>> On Fri, Jan 12, 2018 at 12:16 AM, Tatsuro Yamada
>> <yamada.tatsuro@lab.ntt.co.jp> wrote:
>>> I found a variable (queryEnv) which should be added in
>>> ExplainOneQuery_hook because if it is missing, hook function
>>> can't call ExplainOnePlan.
> 
>> Yeah, I think you're right.  That's an oversight in 18ce3a4a.
> 
> Clearly :-(.  Too bad we didn't find this sooner --- I suppose changing it
> in v10 now is a nonstarter.  Will push to HEAD though.
> 
>             regards, tom lane

Thanks Tom!
I read that commit log on HEAD.

Regards,
Tatsuro Yamada



pgsql-hackers by date:

Previous
From: Tatsuro Yamada
Date:
Subject: Re: add queryEnv to ExplainOneQuery_hook
Next
From: Thomas Munro
Date:
Subject: Re: [HACKERS] Bug in to_timestamp().