Postgres Pro
Downloads
Home   >   mailing lists

Re: add queryEnv to ExplainOneQuery_hook - Mailing list pgsql-hackers

From Tom Lane
Subject Re: add queryEnv to ExplainOneQuery_hook
Date
Msg-id 19370.1515690156@sss.pgh.pa.us
Whole thread Raw
In response to Re: add queryEnv to ExplainOneQuery_hook  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: add queryEnv to ExplainOneQuery_hook  (Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>)
List pgsql-hackers
Tree view 
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Fri, Jan 12, 2018 at 12:16 AM, Tatsuro Yamada
> <yamada.tatsuro@lab.ntt.co.jp> wrote:
>> I found a variable (queryEnv) which should be added in
>> ExplainOneQuery_hook because if it is missing, hook function
>> can't call ExplainOnePlan.

> Yeah, I think you're right.  That's an oversight in 18ce3a4a.

Clearly :-(.  Too bad we didn't find this sooner --- I suppose changing it
in v10 now is a nonstarter.  Will push to HEAD though.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Minor code improvement to estimate_path_cost_size in postgres_fdw
Next
From: Marina Polyakova
Date:
Subject: master make check fails on Solaris 10