Request a Demo
Home   >   mailing lists

Re: More protocol.h replacements this time into walsender.c - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: More protocol.h replacements this time into walsender.c
Date
Msg-id 1a1b279e-69d7-4609-924e-8d52f1201ef0@app.fastmail.com
Whole thread Raw
In response to Re: More protocol.h replacements this time into walsender.c  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: More protocol.h replacements this time into walsender.c
List pgsql-hackers
Tree view 
On Wed, Aug 6, 2025, at 12:26 AM, Nathan Bossart wrote:
> Okay, I think I've addressed all the latest feedback in v5.
>

LGTM.

I tried to apply your patch and it says

$ git am -3 v5-0001-Expand-usage-of-protocol-characters.patch
Applying: Expand usage of protocol characters.
Warning: commit message did not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitEncoding to the encoding your project uses.

It seems your file is ISO-8859-1 but your commit message claims to be UTF-8.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Confine vacuum skip logic to lazy_scan_skip
Next
From: Nathan Bossart
Date:
Subject: Re: More protocol.h replacements this time into walsender.c