Re: [HACKERS] Syntax errors in current tree - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Syntax errors in current tree
Date
Msg-id 199901180648.BAA26158@candle.pha.pa.us
Whole thread Raw
In response to Syntax errors in current tree  ("D'Arcy" "J.M." Cain <darcy@druid.net>)
Responses Re: [HACKERS] Syntax errors in current tree  ("D'Arcy" "J.M." Cain <darcy@druid.net>)
List pgsql-hackers
>  really hesitate to make this criticism given all the work people are
> doing on the system and all the great features and fixes that are
> being added but could we please make it a hard and fast rule that
> nothing gets added into the tree until the person adding it has at
> least compiled the source, if not a full regression test.  I have
> finally jumped in and tried to add full primary key support but I
> keep stumbling over simple syntax errors in files I am not working
> on but that keep me from fully testing my own changes.  Here's what
> I get compiling gram.y[c].

Fixed.  I assume people test the patches before submission, so I don't
usually compile after each one.  I did add some code in gram.y, and that
was what caused the problem.

Sorry.  Blech (Sound of me falling on my sword.  :-))

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Syntax errors in current tree
Next
From: Vadim Mikheev
Date:
Subject: Re: [HACKERS] I need a PostgreSQL vacation