Re: [HACKERS] Minor bugs and a formatting gripe - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Minor bugs and a formatting gripe
Date
Msg-id 199809041553.LAA01464@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Minor bugs and a formatting gripe  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Bruce Momjian <maillist@candle.pha.pa.us> writes:
> >> BUT: I am not happy that the script chooses to reflow block comments.
>
> >      `Box' comments. Indent assumes that any comment with a dash or
> >      star imme- diately after the start of comment (that is, `/*-' or
> >      `/**') is a comment surrounded by a box of stars.  Each line of
> >      such a comment is left un- changed, except that its indentation
> >      may be adjusted to account for the change in indentation of the
> >      first line of the comment.
>
> > Do you still want me to turn it off?
>
> Ah.  OK, learn something new every day ;-).  Now that I know how to
> control it, I can live with it.
>
> A suggestion: it'd be worth making an entry in FAQ_DEV that talks about
> coding style conventions and points out that people should expect to
> have their code reformatted by pgindent.  As I don't have indent
> installed on my system, I have very little idea what to expect from it;
> I can't readily consult the man page.

OK, new pgindent entry is:

   pgindent is run on all source files just before each beta test period.
   It auto-formats all source files to make them consistent. Comment
   blocks that need specific line breaks should be formatted as block
   comments, where the comment starts as /*------. These comments will
   not be reformatted in any way.


--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

pgsql-hackers by date:

Previous
From: "Thomas G. Lockhart"
Date:
Subject: Re: [HACKERS] index fix report
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Re: CIDR/IP types. Was: [GENERAL] big numbers]