Re: Supporting Windows SChannel as OpenSSL replacement - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Supporting Windows SChannel as OpenSSL replacement
Date
Msg-id 19795.1408136243@sss.pgh.pa.us
Whole thread Raw
In response to Re: Supporting Windows SChannel as OpenSSL replacement  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> On 08/15/2014 08:16 PM, Jeff Janes wrote:
>> Should the ereport DEBUG2 be inside the "#ifdef USE_SSL"?

> Yeah.

> I've been thinking though, perhaps we should always have the ssl_in_use, 
> peer_cn and peer_cert_valid members in the Port struct. If not compiled 
> with USE_SSL, they would just always be false/NULL. Then we wouldn't 
> need #ifdefs around all the places that check hose fields either.

+1.  This would also make it less risky for add-on code to touch the Port
struct.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: jsonb format is pessimal for toast compression
Next
From: Arthur Silva
Date:
Subject: Re: jsonb format is pessimal for toast compression